Skip to content

[PYIC-8016] Updated PR template. #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

[PYIC-8016] Updated PR template. #3142

merged 2 commits into from
Apr 28, 2025

Conversation

undermad
Copy link
Contributor

Proposed changes

What changed

Pull Request template

Why did it change

Generalised checklist and removed some unnecessary headers to make it easier to navigate.

Issue tracking

Checklists

  • No secrets were added
  • README and documentation updated where necessary
  • No risk of credentials being exposed through logs
  • API/unit tests have been written/updated

@undermad undermad requested review from a team as code owners April 25, 2025 14:52
@blakeyp
Copy link
Contributor

blakeyp commented Apr 25, 2025

I'm thinking about another one specifically for core-back along the lines of "production changes appropriately staged out". (When we make changes to code already live in prod, we need to consider whether we need to stage out the changes across multiple PRs to maintain backwards compatibility for in-flight user journeys - especially given we do blue-green canary deployments)

@undermad undermad merged commit dcba2b3 into main Apr 28, 2025
6 checks passed
@undermad undermad deleted the PYIC-8016 branch April 28, 2025 09:47
@undermad undermad restored the PYIC-8016 branch April 28, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants